Bop
Remember the Treeline
I appreciate you doing all the numbers sir, I'm not a smart guy so this helps.
I see alot of it as chalking up to preference, circumstances and cooldowns.
Rogues that play alot of Arenas will have different builds as to ones that want to play Battlegrounds.
The most consistent and all-round diversified kit for a rogue (if you cbb rechanging your specs/talents all the time) is .............*drum roll*..............
Race - Night elf (racist I know), Undead (for horde)
Spec - Combat
Talent - Nightstalker
My opinions of course <3
I'm not so sure I agree with your race assessments.
I mean of course Night Elves are head-and-shoulders above any other F2P Rogue spec, for numerous reasons - not the least of which being Vanish.
But Undead for Horde? I think it's a viable choice, especially if you plan to do a lot of arenas where the consistent damage from TotG will add up. Belf or Goblin make a lot more sense to me, at least from the perspective of utility. The Arcane Torrent is hard to argue with as being the best Horde Rogue racial, and comes the closest to even making Nelf Rogues jealous. Goblins have a pseudo-SStep (in addition to Thrall's Gift as a bracers choice, which scales to 10 agility), making them a niche pick for certain playstyles.
I agree with your overall assessments though. Each spec and each talent has its use. I just wish that something as diverse as a Rogue wasn't immediately overshadowed in nearly every form by 1 single Druid class specialization :/