Where did you get those numbers? LS is 180 per minute, 140/60 would equal 2.66, why are you reducing the number from 2.33 to 1.96? Why is 15 AGI giving a rouge 22.5 AP when it gives 1 AP per AGI, why do you assume 60 DPS? Why is crusader listed as 150 AP it gives 100 STR which is 100 AP for a rogue, why do you assume all 15 seconds are useful each time?
Here's how I decided Lifesteal was the best in most situations : ) Generally I do more damage when I'm alive and weight survivability and damage pretty equally. In many fights if I live longer, then I'm more likely to kill them.
Lifesteal and Fiery have 6 PPM, Crusader is 1 PPM. Proc chance scales with weapon speed. So auto attacks will match this rate.
Sinister Strike costs 40 energy (when talented), 20 energy are generated every 2 seconds, so you can perform 1 SS per 4 seconds. 2.7 (Shadowfang swing time) / 4 = 0.675 bonus attacks from Sinister Strike per main hand swing.
14 attack power = 1 DPS to the main hand weapon, 0.5 DPS to the off-hand weapon, and 0.675 DPS extra due to Sinister Strikes = 2.175 DPS * (1 + Critical Strike %)
1 Attack Power = 0.155 DPS * (1 + Critical Strike %)
To get the value for 1% of physical critical strike chance is a little more complicated. We will need to determine total physical damage output, divide it by 100, and then divide it by amount of critical strike chance we already have. For now I will use the values listed on my character sheet with no world buffs:
32.69 DPS main hand * 1.675 main hand attacks
15.20 DPS off hand
10 Sinister Strike Rank 3 Damage Bonus * 0.25 Sinister Strikes per second = 2.5 DPS
Total: 72.46 DPS (before crit)
1% Crit = 0.566 DPS (72.46 / 100 = 0.7246 / 1.28 (@28% crit))
Agility is worth: 0.273 DPS
1 Attack Power = 0.155 * 1.28 (@28% crit) = 0.198 DPS
0.1316% Critical Strike Chance = 0.1316 * 0.566 DPS = 0.0745 DPS
Fiery adds a base of 40 damage * 6 procs = 240 damage per minute / 60 seconds = 4 Fire DPS
Lifesteal adds a base 30 damage + healing * 6 procs = 180 damage per minute and 180 heals per minute = 3 Shadow DPS + 3 Shadow HPS
15 Agility * 0.273 per Agility = 4.1 Physical DPS
Crusader adds 100 healing + 100 attack power for 15 seconds per minute.
If we assume you stay glued to the target 80% of each proc and it never procs while up it will give: 100 * 0.198 * 15 seconds per minute * 0.80 (80% usage) = 237.6 damage per minute / 60 = 3.96 Physical DPS
And of course 100 healing per minute / 60 = 1.67 HPS
We are nearly ready to compare each enchant : ) For the comparison below I will list the type of DPS and then I will use Cennix's defense weights against a bear tank to adjust the end result into a standardized DPS score.
Armor: 40% damage reduction (Multiplier 0.60)
Magic: 8% resist (Multiplier 0.9225)
Now we can compare each enchant:
Main Hand
Fiery = 4 * 1.675 DPS = 6.7 Fire DPS * 0.9225 = 6.2 DPS
LS = 3 * 1.675 DPS + HPS = (5 Shadow DPS + HPS) * 0.9225 = 4.6 DPS + HPS
15 AGI = 4.1 Physcial DPS * 0.60 = 2.46 DPS
Crusader = (3.96 DPS + 1.67 HPS) * 1.675 = 6.6 Physical DPS * 0.60 + 2.79 HPS = 4 DPS + 2.8 HPS
Off-Hand
Fiery = 4 Fire DPS * 0.9225 = 3.7 DPS
LS = 3 Shadow DPS + HPS * 0.9225 = 2.8 DPS + HPS
15 AGI = 4.1 Physcial DPS * 0.60 = 2.46 DPS
Crusader = 3.96 Physical DPS * 0.60 + 1.67 HPS = 2.4 DPS + 1.7 HPS
With those it's easy to see you want something that procs in your main hand. If you value HPS at greater than 1/3rd of the value of DPS Lifesteal wins : )
Addendum: For simplicity I left off the survivability portions of Agility, I might as well quickly list it's expected value, but will skip the detailed breakdown unless someone requests it.
Each AGI gives 0.2633% Dodge valued at 0.25 Stamina (assuming 45% of damage taken is melee, 45% ranged, 10% magic) + 2 Armor valued at 0.09 Stamina. So 15 AGI = 5.1 Stamina or 51 HP
If you play rogue objectively or competitively I don't see why you would value HPS > DPS at all.
First of all generally speaking an FC has peelers, roots, healers and so forth, not to mention constantly on the move and trying to lose you. So as Cennix already stated the window you get to apply damage is minimal.
Your sole purpose as a Rogue is to connect, and apply as much damage as you possibly can into that small time you get. So your HPS is an opportunity forgone in this scenario. Also when you take into consideration in a 10v10 Scenario the Enemy Team generally speaking has almost 0 damage in defence and operate purely to kite, heal and separate you from the FC. Which can often be the case in pugs too, but harder to predict.
HPS is again not needed, considering you generally have a Priest on O, or other utility classes which can top you up from the minimal damage.
So as a Rogue, who plays objectively? then your BiS is very clear, x2 Fiery weapon. Literally no competition or arguements; Kill FC? Fiery Weapon.
Gear wise, there is 2 further options, you can actually get more DPS if you stack AP bonus rather than Agi/Stam, Iv got a set like this but unfortunately gives 650-700hp. Pretty much a meme Glass Cannon build, but it really does put the damage in when you don't need to worry about your hp. Used to use that in premades, and still never really died due to lack of damage on Defence.
Only gear option I might rate over DPS for killing an FC is, resistance. If you can resist the slows, roots and fears, then you theoretically connect for a while longer, which lets you put more damage in. So gimping DPS for Resistance is acceptable.
So again as Cennix said, if you want to play objectively, Fiery is by far superior in every way.
If you want to play the Dodge game vs Rogues/Hunters, then buy a 2nd set with AGI.
