PvP:
Proffession wise, i would take Engineering for the absorb shield and the 480str on use effect as it makes a huge difference as opposed to passive stats where you arn't constantly on the target.
the state of the warrior is directly linked to how well you can play warriors at this bracket, if you don't know how to utilise every single one of your cooldowns properly you will die a lot, and i mean a lot in PvP as it's very easy to counter a warrior, the damage that warriors can put out is really high, although it's average compared to what subelty rogues can dish out during Find Weakness.
PvE:
Proffesion wise, I would take Inscription for DPS and Blacksmithing for protection as you can get an extra 90 mastery which is huge, although if you choose to go a certain build you won't need anymore mastery therefore inscription would be better but this is for you, and only you to decide.
I find that they are no where near as strong as alot of other DPS, it is very hard to compete with Assasination Rogues, Arcane Mages etc etc, If you want to be a real use to the raid group in a PvE situation then i suggest going Protection, protection warriors are by far the best tanks at level 80 raiding in my opinion due to the mastery and the way that critical block works.